Update cookbook usage to handle multiple rosdistros.#496
Merged
brawner merged 15 commits intobrawner/ros2_windows_cheffrom Jul 21, 2020
Merged
Update cookbook usage to handle multiple rosdistros.#496brawner merged 15 commits intobrawner/ros2_windows_cheffrom
brawner merged 15 commits intobrawner/ros2_windows_cheffrom
Conversation
Instead of using separate dockerfiles for different ROS distros this uses separate chef environment files to set a ros_distro attribute which can be used inside the chef cookbook. If this is successful we can unify the separate Dockerfiles and modify software in the chef cookbook.
I forgot that environment paths must be configured instead of specifying an absolute path to an environment file.
Unlike cookbook_path, environment_path must be a single string.
We're going to instead add the attribute directly to the install_ros2.json files.
With the setup being performed by chef the Dockerfiles aren't distinct enough to warrant separate files and we can instead use a single dockerfile with different chef attributes. This also means we can stop fudging the ros_distro parameter since the common behavior is also implemented in Chef.
brawner
approved these changes
Jul 20, 2020
Contributor
brawner
left a comment
brawner
left a comment
There was a problem hiding this comment.
Has this been tested or should I run it once it's merged into the target branch?
Member
Author
I've run a handful of test builds to make sure I got this right during development. These just build up to rcutils and so aren't comprehensive but they test that chef runs to completion. We'll want to do some full CI builds of the final RC PR. Foxy |
delete-merged-branch
bot
deleted the
nuclearsandwich/update-ros2-windows-chef
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update should be applied to #425 before merging it.
With this change the differences in configuration and installed software are delegated to the chef cookbook which means there's no longer a reason for rosdistro-specific dockerfiles.
The different json files set the ros_distro attribute appropriately and change the run-list to install additional rmw providers if they are supported by the distro.