Revert "Force xunit2 for pytest 6.0 when legacy mode is enabled"#468
Merged
nuclearsandwich merged 1 commit intomasterfrom Jun 8, 2020
Merged
Revert "Force xunit2 for pytest 6.0 when legacy mode is enabled"#468nuclearsandwich merged 1 commit intomasterfrom
nuclearsandwich merged 1 commit intomasterfrom
Conversation
This reverts commit 3f57d6d.
clalancette
approved these changes
Jun 8, 2020
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI (particularly on Windows and macOS).
Member
Author
|
CI up to rcutils only since we just want to know that builds can run.
Extra macos build on mini1 which was the problem node in the nightlies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #415 in order to restore Windows and macOS CI which is broken by the absence of pytest in early stages of the build on those platforms. #467 is open to track restoring #415 with corrected behavior after this revert is merged.