Add --ros-distro batch job argument from CI parameter.#455
Merged
nuclearsandwich merged 2 commits intomasterfrom Jul 9, 2020
Merged
Add --ros-distro batch job argument from CI parameter.#455nuclearsandwich merged 2 commits intomasterfrom
nuclearsandwich merged 2 commits intomasterfrom
Conversation
Expands on the work from #450 to expose the CI parameter as a batch job argument. This is needed in order to install different Python wheels when running in the Windows debug configuration.
Member
Author
|
Test deployed CI job to make sure that this unused parameter does not break anything and is passed in CI_ARGS. |
dirk-thomas
approved these changes
May 20, 2020
jacobperron
approved these changes
May 20, 2020
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
jacobperron
approved these changes
May 20, 2020
dirk-thomas
reviewed
Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands on the work from #450 to expose the CI parameter as a batch job
argument. This is needed in order to install different Python wheels for different ROS distros when running in the Windows debug configuration. As those are installed by the batch job script on each run (See
ros2_batch_job/__main__.py).