Exit batch script with error if docker commands fail#428
Merged
nuclearsandwich merged 1 commit intomasterfrom Apr 14, 2020
Merged
Exit batch script with error if docker commands fail#428nuclearsandwich merged 1 commit intomasterfrom
nuclearsandwich merged 1 commit intomasterfrom
Conversation
Member
|
@brawner there's a conflict that needs to be resolved. If you give me the 👌 I'll do a dry run to make sure this PR doesn't introduce a deploy error then merge and deploy it this afternoon. |
brawner
force-pushed
the
brawner/exit_on_failure
branch
from
d00fbb7 to
3dee491
Compare
Member
|
@cottsay since this PR touches the job templates only I'm not sure that your CI job exercised it at all. Am I missing something? |
Member
|
You're correct - I was mistaken. |
nuclearsandwich
approved these changes
Apr 14, 2020
Member
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
Works when dry-run locally.
Member
|
Deployed |
This was referenced Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If commands fail in a batch script, it tends to continue without failing. Unfortunately, there is not a cmd equivalent of
set -eso it's common to use the|| exit /b %errorlevel%paradigm used below. I'm adding it to just the commands that are likely to fail in this script.Depends on #427
New commit: d00fbb7