Skip to content

Patch pytest.ini files present in ROS packages to include xunit2 format #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-rivero merged 6 commits into from
Mar 11, 2020
Merged

Patch pytest.ini files present in ROS packages to include xunit2 format #406

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
603cbc2
Add pytest.ini in the build directory
Mar 11, 2020
4902aa7
Try to patch all pytest.ini files
Mar 11, 2020
add260e
Patch pytest.ini files in packages
Mar 11, 2020
1d09f23
Fix grammar
Mar 11, 2020
a6ce403
Use ConfigParser to manipulate ini file
Mar 11, 2020
5e1884c
Reorder imports and use relative paths in ConfigParser
Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ros2_batch_job/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
# limitations under the License.

import argparse
import configparser
import os
from pathlib import Path
import platform
from shutil import which
import subprocess
Expand Down Expand Up @@ -380,6 +382,21 @@ def build_and_test(args, job):
# xunit2 format is needed to make Jenkins xunit plugin 2.x happy
with open('pytest.ini', 'w') as ini_file:
ini_file.write('[pytest]\njunit_family=xunit2')
# check if packages have a pytest.ini file and add the xunit2
# format if it is not present
for path in Path('.').rglob('pytest.ini'):
config = configparser.ConfigParser()
config.read(str(path))
try:
# only if xunit2 is set continue the loop with the file unpatched
if config.get('pytest', 'junit_family') == 'xunit2':
continue
except configparser.NoOptionError:
pass
print('xunit2 patch applied to ' + str(path))
config.set('pytest', 'junit_family', 'xunit2')
with open(path, 'w+') as configfile:
config.write(configfile)

test_cmd = [
args.colcon_script, 'test',
Expand Down