Basic functionality for loading introspection type support libraries#279
Merged
Basic functionality for loading introspection type support libraries#279
Conversation
c3e2b31 to
567e782
Compare
Collaborator
|
@nnmm have you looked into https://github.com/PlotJuggler/plotjuggler-ros-plugins/tree/development/plugins/ros2_introspection? This may solve a similar problem and/or serve as inspiration. |
Contributor
Author
jhdcs
previously approved these changes
Oct 17, 2022
Collaborator
jhdcs
left a comment
There was a problem hiding this comment.
Sorry for the wait, this seems good to me! I don't see any glaring issues, at any rate.
Contributor
Author
This commit intentionally leaves out an important part of the DynamicMessageMetadata type: The representation of the message structure. This will follow in another commit.
9dcfb0e to
aa77231
Compare
aa77231 to
bb90e6f
Compare
Contributor
Author
|
@jhdcs Could you reapprove? I had to rebase onto main. |
jhdcs
approved these changes
Oct 26, 2022
Contributor
Author
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a topic type in the form of a string like "geometry_msgs/msg/Pose", this will
MessageTypeNametype)lib/libgeometry_msgs__rosidl_typesupport_introspection_c.so(via theament_rscrate)libloading(seeget_type_support_library())get_type_support_handle())This commit intentionally leaves out an important part of the
DynamicMessageMetadatatype: The representation of the message structure. This will follow in another commit.