Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for service #218

Closed

Conversation

i-am-chauhan
Copy link

This PR adds a function(wait_for_service) in client to wait for service to be up .

@i-am-chauhan i-am-chauhan changed the base branch from main to client-services July 5, 2022 15:36
@esteve
Copy link
Collaborator

esteve commented Jul 6, 2022

@i-am-chauhan thanks! This is great, however I'd prefer not to use thread::sleep in the library (for examples that should be fine). The way rclcpp solves this is by using guard conditions and the ROS graph (https://github.com/ros2/rclcpp/blob/rolling/rclcpp/src/rclcpp/client.cpp#L169-L170), which are currently not implemented in rclrs

@i-am-chauhan
Copy link
Author

@esteve , okay I was taking rclpy as reference which does the same what I have done.
I'll see if I can do it as rclcpp.

@delete-merged-branch delete-merged-branch bot deleted the branch ros2-rust:client-services July 8, 2022 12:43
@nnmm
Copy link
Contributor

nnmm commented Aug 21, 2022

After #249 is merged, this could be redone using guard conditions.

@Carter12s Carter12s mentioned this pull request Oct 25, 2023
@esteve
Copy link
Collaborator

esteve commented Aug 15, 2024

Superseded by #339, which is in main. Thanks @i-am-chauhan for starting the work on this.

@esteve esteve closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants