convert xacro to pure python package to allow running in Windows#303
convert xacro to pure python package to allow running in Windows#303wmmc88 wants to merge 1 commit into
Conversation
|
Tested locally and running via |
rhaschke
left a comment
There was a problem hiding this comment.
Thanks for providing a potential fix for #302. However, I wasn't expecting such a huge changeset. Switching the build type from ament_cmake to ament_python is not an option as we provide some cmake functionality to other packages via xacro-extras.cmake. Can you think of another option? What is the actual culprit of #302, i.e. what's the difference of installed files?
My understanding is that in windows, running a python script like an executable is just not possible like it is in linux. Linux seems to be able to do this because it interprets the shebang and that's not something that windows does. All of the rqt packages(ie. rqt_graph, rqt_console, rqt_plot, rqt_action, etc. ) solved this issue by converting their packages to a pure python package so that colcon would be able to use the setup.py to create and entrypoint script that is invokable via It seems like |
closes #302