Skip to content

navigation2: 1.1.3-1 in 'humble/distribution.yaml' [bloom]#35270

Merged
methylDragon merged 1 commit intoros:masterfrom
SteveMacenski:bloom-navigation2-37
Nov 10, 2022
Merged

navigation2: 1.1.3-1 in 'humble/distribution.yaml' [bloom]#35270
methylDragon merged 1 commit intoros:masterfrom
SteveMacenski:bloom-navigation2-37

Conversation

@SteveMacenski
Copy link
Member

Increasing version of package(s) in repository navigation2 to 1.1.3-1:

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Nov 9, 2022
@methylDragon
Copy link
Contributor

@methylDragon methylDragon added the held for sync Issue/PR has been held because the distribution is in a sync hold label Nov 10, 2022
@SteveMacenski
Copy link
Member Author

SteveMacenski commented Nov 10, 2022

@methylDragon this PR predates that hold 😢 This is also a pretty important set of updates to get out ASAP with bug fixes impacting users

@methylDragon
Copy link
Contributor

@methylDragon this PR predates that hold cry This is also a pretty important set of updates to get out ASAP with bug fixes impacting users

@SteveMacenski okay, I'll merge it.

I'll need to monitor for regressions on the various status pages and revert if there are regressions though. So note that this might get reverted if it causes issues.

@methylDragon methylDragon merged commit cf3ee0a into ros:master Nov 10, 2022
@methylDragon
Copy link
Contributor

@SteveMacenski looks like nav2 isn't working in RHEL https://build.ros2.org/view/Hbin_rhel_el864/job/Hbin_rhel_el864__nav2_constrained_smoother__rhel_8_x86_64__binary/17/

15:14:34 DEBUG: In file included from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother_cost_function.hpp:32,
15:14:41 DEBUG:                  from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother.hpp:29,
15:14:41 DEBUG:                  from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/constrained_smoother.hpp:26,
15:14:41 DEBUG:                  from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/src/constrained_smoother.cpp:23:
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/utils.hpp: In function 'Eigen::Matrix<_Scalar, 2, 1> nav2_constrained_smoother::tangentDir(Eigen::Matrix<_Scalar, 2, 1>, Eigen::Matrix<_Scalar, 2, 1>, Eigen::Matrix<_Scalar, 2, 1>, bool)':
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/utils.hpp:89:14: error: 'isinf' is not a member of 'ceres'
15:14:41 DEBUG:    if (ceres::isinf(center[0])) {  // straight line
15:14:41 DEBUG:               ^~~~~
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/utils.hpp:89:14: note: suggested alternative: 'sinh'
15:14:41 DEBUG:    if (ceres::isinf(center[0])) {  // straight line
15:14:41 DEBUG:               ^~~~~
15:14:41 DEBUG:               sinh
15:14:41 DEBUG: In file included from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother.hpp:29,
15:14:41 DEBUG:                  from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/constrained_smoother.hpp:26,
15:14:41 DEBUG:                  from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/src/constrained_smoother.cpp:23:
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother_cost_function.hpp: In member function 'void nav2_constrained_smoother::SmootherCostFunction::addCurvatureResidual(const double&, const Eigen::Matrix<_Scalar, 2, 1>&, const Eigen::Matrix<_Scalar, 2, 1>&, const Eigen::Matrix<_Scalar, 2, 1>&, T&) const':
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother_cost_function.hpp:162:16: error: 'isinf' is not a member of 'ceres'
15:14:41 DEBUG:      if (ceres::isinf(center[0])) {
15:14:41 DEBUG:                 ^~~~~
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother_cost_function.hpp:162:16: note: suggested alternative: 'sinh'
15:14:41 DEBUG:      if (ceres::isinf(center[0])) {
15:14:41 DEBUG:                 ^~~~~
15:14:41 DEBUG:                 sinh

@SteveMacenski
Copy link
Member Author

@methylDragon Nav2 has never worked on rhel, I don't believe. Pretty much every project I work on should be on the RHEL blacklist in the build farm configuration

@methylDragon
Copy link
Contributor

Hmm, okay, I think everything's okay then 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

held for sync Issue/PR has been held because the distribution is in a sync hold humble Issue/PR is for the ROS 2 Humble distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants