add verbiage about overriding 3rdparty content#29913
Merged
Conversation
clalancette
requested changes
Jun 15, 2021
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Minor wording changes.
jacobperron
reviewed
Jun 16, 2021
jacobperron
approved these changes
Jun 17, 2021
clalancette
requested changes
Jun 17, 2021
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
A few more things I noticed while going through this.
Member
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
Overall this is a great addition to our contributing docs and it's going to help contributors and reviewers alike. I've added some suggestions and there are a few in flight from other reviewers. Otherwise it is looking good!
ivanpauno
approved these changes
Aug 25, 2021
Contributor
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM, with clalancette and nuclearsandwich comments addressed.
clalancette
reviewed
Sep 7, 2021
clalancette
reviewed
Sep 7, 2021
clalancette
reviewed
Sep 7, 2021
clalancette
reviewed
Sep 7, 2021
clalancette
reviewed
Sep 7, 2021
clalancette
reviewed
Sep 7, 2021
clalancette
reviewed
Sep 7, 2021
clalancette
approved these changes
Sep 7, 2021
The majority of the content is from: https://discourse.ros.org/t/release-package-requiring-custom-version-of-system-dependency/18200/6?u=tfoote Following up: #29614 (comment)
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Co-authored-by: Tully Foote <tfoote@osrfoundation.org>
clalancette
force-pushed
the
rosdep_conflicts
branch
from
aa4b503 to
ac05b33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The majority of the content is from: https://discourse.ros.org/t/release-package-requiring-custom-version-of-system-dependency/18200/6?u=tfoote
Following up: #29614 (comment)