Update Ignition rosdep keys#25789
Update Ignition rosdep keys#25789tfoote merged 2 commits intoros:masterfrom chapulina:chapulina/update_ignition
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
Sounds reasonable to me. (To pass CI the renamed entries must be moved into alphabetical order.) |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
@tfoote has been the driving editorial force behind rosdep keys. I'd like to give him the opportunity to review or explicitly abstain from doing so. |
tfoote
left a comment
There was a problem hiding this comment.
Yeah, in general we pick the debian names because it's the most generic. However if this can work with the upstream packages from source too then an exception to that makes sense.
The biggest thing though that I'd point out is that if you do this you do not have the ability to explicitly call out the runtime libraries versus the development libraries which is valuable for packing. But I guess in the future we can consider explicitly adding lib* and *-dev keys in parallel. But for now if this works for both source space and rosdep resolutions that sounds like a win.
So... I left the |
|
That's a good compromise. |
Originally on #24934 we added rosdep keys that matched the debian package names as recommended by the reviewers: #24934 (comment).
However, this makes usage of these keys complicated when compiling Ignition libraries (pure CMake packages) and ROS packages together in the same colcon workspace (our team often does this).
Here's an example that can be in the same colcon workspace as Ignition:
However, the above doesn't work with
rosdep install. Ideally, we'd declare Ignition dependencies once, and they would work with eitherrosdeporcolcon.Therefore, I propose here that we change the
-devkeys to match the CMake project names.Let me know if this is a big taboo and we can discuss alternatives.
CC @j-rivero @sloretz @dirk-thomas