Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind11_catkin: 2.2.3-1 in 'indigo/distribution.yaml' [bloom] #18282

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

wxmerkt
Copy link
Contributor

@wxmerkt wxmerkt commented Jun 27, 2018

Increasing version of package(s) in repository pybind11_catkin to 2.2.3-1:

@tfoote
Copy link
Member

tfoote commented Jun 27, 2018

Rebuilding after #18283

Note that this can go into indigo and kinetic but not melodic as pybind11 is available as of artful: https://packages.ubuntu.com/artful/pybind11-dev

@tfoote
Copy link
Member

tfoote commented Jun 27, 2018

Sorry apparently this needs a rebase on the above changes to pass CI. I thought it would test post merge.

@wxmerkt
Copy link
Contributor Author

wxmerkt commented Jun 27, 2018

Thanks @tfoote about the note regarding the release in Ubuntu Artful and later. We are adding extra CMake macros on top of the external project (cf. here) so may consider releasing just those without the source checkout for melodic if that's ok?

I also rebased on master.

@tfoote
Copy link
Member

tfoote commented Jun 27, 2018

If you're just adding cmake_macros that would be reasonable. You could also consider submitting them to https://github.com/ros/cmake_modules

@tfoote tfoote merged commit 0a7e648 into ros:master Jun 27, 2018
tfoote added a commit that referenced this pull request Jul 3, 2018
Removing the version will effectively remove it

Reverts #18282 due to not building wxmerkt/pybind11_catkin#1
tfoote added a commit that referenced this pull request Jul 4, 2018
Removing the version will effectively remove it

Reverts #18282 due to not building wxmerkt/pybind11_catkin#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants