Removed ros1 tutorials from ros2 branch #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
friendly ping @clalancette |
clalancette
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
This looks good to me with green CI.
@ahcorde I hope you don't mind if I ask for one more favor in connection with this repository. In particular, in the distribution.yaml entry that corresponds to this repository, the top-level key is called turtlesim. That means that when we go to bloom-release this package, we always have to do bloom-release turtlesim. But that is in contrast to basically all other packages, where you always need to use the name of the repository, not the package. That is, it makes more sense to me to be able to do bloom-release ros_tutorials, and have turtlesim be one of the packages. If you could look into fixing that, it would be much appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According with this comment #109 (comment) these tutorials are located in a different place. We should remove them from here to avoid inconsistencies