Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Galactic] Update maintainers #106

Merged
merged 1 commit into from
Oct 13, 2020
Merged

[Galactic] Update maintainers #106

merged 1 commit into from
Oct 13, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Oct 12, 2020

Previous: Dirk Thomas
Current: Mabel Zhang ; Shane Loretz

Signed-off-by: Shane Loretz[email protected]
Signed-off-by: Shane Loretz [email protected]

@mabelzhang mind taking a look?

@sloretz
Update maintainers
cf46358 
Previous: Dirk Thomas
Current: Mabel Zhang ; Shane Loretz

Signed-off-by: Shane Loretz<[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
@sloretz sloretz self-assigned this Oct 12, 2020
mabelzhang
mabelzhang approved these changes Oct 12, 2020
View reviewed changes
Copy link

@mabelzhang mabelzhang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you haven't hidden an easter egg in one of these email addresses that I didn't read word for word.

@dirk-thomas
Copy link
Member

Only the turtlesim package is being used in ROS 2. All other packages are being ignored - not sure if it makes sense to update them. Maybe they could just be removed altogether.

@dirk-thomas dirk-thomas mentioned this pull request Oct 13, 2020
Merged
@sloretz
Copy link
Contributor Author

sloretz commented Oct 13, 2020

Cherry pick of #102

Only the turtlesim package is being used in ROS 2. All other packages are being ignored - not sure if it makes sense to update them. Maybe they could just be removed altogether.

Yeah, I'll update them for now. In the meantime I opened #109 to capture this thought.

@sloretz sloretz merged commit 5d2f22a into galactic-devel Oct 13, 2020
@sloretz sloretz deleted the galactic-devel_maintainers branch October 13, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabelzhang mabelzhang mabelzhang approved these changes

@dirk-thomas dirk-thomas Awaiting requested review from dirk-thomas

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloretz @dirk-thomas @mabelzhang