[roslaunch-check] Use roslaunch.core.printerrlog for printing error message. #1193
Conversation
…essage. Errors are printed without much stress, which makes hard to find the specific error occurred.
130s
force-pushed
the
l/roslaunch-check_color
branch
from
dc554ed to
d182f42
Compare
| @@ -116,7 +117,7 @@ if __name__ == '__main__': | |||
| message = "roslaunch check [%s] failed"%(roslaunch_path) | |||
| f.write(rosunit.junitxml.test_failure_junit_xml(test_name, message, stdout=error_msg, | |||
| class_name="roslaunch.RoslaunchCheck", testcase_name="%s_%s" % (pkg, outname))) | |||
| print("wrote test file to [%s]"%test_file) | |||
| roslaunch.core.printerrlog("wrote test file to [%s]"%test_file) | |||
There was a problem hiding this comment.
This doesn't seem to be an error message?
There was a problem hiding this comment.
This if block is when error occurred. To highlight the file path this change is still useful.
|
Thank you for the patch. |
|
Thank you for the review @dirk-thomas. |
|
There will likely be another Lunar release in the near term and after that a batch backport to Kinetic. All changes will be considered - the usual rational applies if a change should be backported. While this patch has little impact and wouldn't be necessary it also poses very little risk. Will see when doing the backporting. |
| @@ -219,10 +219,10 @@ def check_roslaunch(f, use_test_depends=False): | |||
| print(e, file=sys.stderr) | |||
| miss_all = True | |||
| if miss_all: | |||
| print("Missing package dependencies: %s/package.xml: %s"%(pkg, ', '.join(miss)), file=sys.stderr) | |||
| roslaunch.core.printerrlog("Missing package dependencies: %s/package.xml: %s"%(pkg, ', '.join(miss)), file=sys.stderr) | |||
There was a problem hiding this comment.
The new function doesn't support the file keyword argument. See #1317.
Errors are printed without much stress, which makes hard to find the specific error occurred.