Skip to content
This repository was archived by the owner on Aug 3, 2020. It is now read-only.

load libpcrecpp before collada-dom, fixes #89#105

Merged
isucan merged 1 commit into
ros:indigo-develfrom
k-okada:add_pcre_collada_urdf
Apr 20, 2015
Merged

load libpcrecpp before collada-dom, fixes #89#105
isucan merged 1 commit into
ros:indigo-develfrom
k-okada:add_pcre_collada_urdf

Conversation

@k-okada
Copy link
Copy Markdown
Contributor

@k-okada k-okada commented Apr 18, 2015

No description provided.

isucan added a commit that referenced this pull request Apr 20, 2015
load libpcrecpp before collada-dom, fixes #89
@isucan isucan merged commit 137268d into ros:indigo-devel Apr 20, 2015
@davetcoleman
Copy link
Copy Markdown
Contributor

wow, great fix!

Comment thread collada_urdf/package.xml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is pcrecpp different from pcre or pcre-dev?

https://github.com/ros/rosdistro/blob/master/rosdep/base.yaml#L2619-L2632

I don't see pcrecpp in the rosdep database.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna go with no, based on the stuff I've looked at, I'm going to change this to pcre and pcre-dev. @isucan

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @wjwwood

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants