Skip to content

Add .hpp header and deprecate .h#51

Merged
sloretz merged 2 commits intoros2from
sloretz/deprecate_h_for_hpp
Aug 7, 2020
Merged

Add .hpp header and deprecate .h#51
sloretz merged 2 commits intoros2from
sloretz/deprecate_h_for_hpp

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Aug 6, 2020

This PR is two commits and should be rebase and merged to capture the moved file in history. The first commit renames retriever.h to retriever.hpp with no other changes. The second commit creates a new retriever.h that warns it is deprecated and includes retriever.hpp as well as making the code changes to use retriever.hpp.

sloretz added 2 commits August 6, 2020 14:35
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz requested a review from clalancette August 6, 2020 21:48
@sloretz sloretz self-assigned this Aug 6, 2020
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Aug 6, 2020

CI linux build: --packages-above resource_retriever test: --packages-select resource_retriever to look for warnings downstream: Build Status

Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question, and it looks like CI failed. Once those are fixed this is fine with me, thanks for doing this.

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Aug 7, 2020

One minor question, and it looks like CI failed.

Oops, I used the wrong build args. New build --packages-above-and-dependencies resource_retriever test --packages-select resource_retriever

  • Linux Build Status
  • Windows Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Aug 7, 2020

CI (build: --packages-above-and-dependencies resource_retriever test: --packages-select resource_retriever rviz_common rviz_default_plugins rviz_rendering rviz_rendering_tests)

  • Linux Build Status
    • java traceback, rebuilding: Build Status
  • Linux-aarch64 Build Status
    • java traceback, rebuilding: Build Status
      • java traceback, rebuilding: Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 854c836 into ros2 Aug 7, 2020
@sloretz sloretz deleted the sloretz/deprecate_h_for_hpp branch August 7, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants