Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
clalancette
reviewed
Aug 7, 2020
Contributor
clalancette
left a comment
There was a problem hiding this comment.
One minor question, and it looks like CI failed. Once those are fixed this is fine with me, thanks for doing this.
Contributor
Author
clalancette
approved these changes
Aug 7, 2020
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is two commits and should be rebase and merged to capture the moved file in history. The first commit renames
retriever.htoretriever.hppwith no other changes. The second commit creates a newretriever.hthat warns it is deprecated and includesretriever.hppas well as making the code changes to use retriever.hpp.