This repository was archived by the owner on May 31, 2025. It is now read-only.
[kinetic] [Windows] Rename catkin scripts for parallel package parsing support#1066
Merged
dirk-thomas merged 3 commits intoros:kinetic-develfrom Feb 25, 2020
Merged
Conversation
Contributor
Author
|
@dirk-thomas This is ready for review and merge. Thanks! |
Member
|
Since Noetic doesn't support Python 2 maybe this change should target the |
seanyen
force-pushed
the
fix_multiprocessing
branch
from
0576436 to
935fb74
Compare
Contributor
Author
|
@dirk-thomas Thanks. I rebased and targeted this pull request to |
dirk-thomas
changed the title
dirk-thomas
changed the title
Member
|
Thanks for the patch / update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another attempt to solve the parallel packages parsing support: (Here are related attempts.)
Based on current investigation, on Windows\Python2, we have to make the scripts to be ended with
.py; Otherwise, any usage of multiprocessing will result inImportError: No module named <catkin_script_name>.This attempt is to only do the renaming on Windows when
setup.pyruns, so the<catkin_script>.pywill be installed in this case.This fixes ms-iot/ROSOnWindows#148.