Closed
Conversation
Instead of using the node created by the rqt plugin host, create one for the topic monitor plugin to use one so that this plugin can have subscriptions come and go without crashing the app. Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
|
Same questions than ros-visualization/rqt_console#30 (review). |
Author
|
@ivanpauno See ros-visualization/rqt_console#30 for a description. |
Contributor
|
@mjeronimo mind checking if ros2/rclpy#761 fixes the issue this is trying to solve? |
Author
|
Closing in favor of ros2/rclpy#761. I'll open a separate PR to remove the output messages that will become obsolete once 761 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using the node created by the rqt plugin host, create
one for the topic monitor plugin to use one so that this plugin
can have subscriptions come and go without crashing the app.
Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org