Skip to content

Fixed interfaces icons on Windows and MacOS#9

Closed
ahcorde wants to merge 1 commit into
ahcorde/fix_runfrom
ahcorde/fix/icons
Closed

Fixed interfaces icons on Windows and MacOS#9
ahcorde wants to merge 1 commit into
ahcorde/fix_runfrom
ahcorde/fix/icons

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented May 27, 2020

This PR fixes the issues with icons on Windows and MacOS.

According with the documentation

  • Note: By default, only X11 will support themed icons. In order to use themed icons on Mac and Windows, you will have to bundle a compliant theme in one of your themeSearchPaths() and set the appropriate themeName().

Related with this PR #8

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from jacobperron May 27, 2020 11:23
@ahcorde ahcorde self-assigned this May 27, 2020
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Jun 1, 2020

Closing this PR in favour of this other PR ros2/ros2#928

@ahcorde ahcorde closed this Jun 1, 2020
@clalancette clalancette deleted the ahcorde/fix/icons branch August 11, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant