Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

[ros2] Port hand of god to ROS2#957

Merged
chapulina merged 2 commits intoros-simulation:dashingfrom
shiveshkhaitan:hand_of_god
Aug 2, 2019
Merged

[ros2] Port hand of god to ROS2#957
chapulina merged 2 commits intoros-simulation:dashingfrom
shiveshkhaitan:hand_of_god

Conversation

@shiveshkhaitan
Copy link
Copy Markdown

Port gazebo_ros_hand_of_god plugin to ROS2.

Example usage:

<plugin name="hand_of_god" filename="libgazebo_ros_hand_of_god.so">
  <ros>
    <namespace>/demo</namespace>
  </ros>
  <link_name>link</link_name>
  <frame_id>link</frame_id>
</plugin>

Migration guide at ROS 2 Migration: Hand of God

@chapulina chapulina self-requested a review July 17, 2019 15:33
@chapulina chapulina added the ros2 label Jul 17, 2019
@chapulina
Copy link
Copy Markdown
Contributor

@osrf-jenkins run tests please

Copy link
Copy Markdown
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just have a couple of small comments, and it needs rebasing

Comment thread gazebo_plugins/src/gazebo_ros_hand_of_god.cpp
Comment thread gazebo_plugins/src/gazebo_ros_hand_of_god.cpp Outdated
Comment thread gazebo_plugins/include/gazebo_plugins/gazebo_ros_hand_of_god.hpp
@chapulina chapulina merged commit d84c473 into ros-simulation:dashing Aug 2, 2019
shiveshkhaitan added a commit to shiveshkhaitan/gazebo_ros_pkgs that referenced this pull request Aug 15, 2019
* [ros2] Port hand of god to ROS2

* Minor fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants