This repository was archived by the owner on Jul 10, 2025. It is now read-only.
[ros2] Fix tests on Dashing #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine. and two other places. Even this doesn't come up while compiling as the test is commented for now |
chapulina
force-pushed
the
triggered_test
branch
from
89a8d87 to
b08698b
Compare
Contributor
Author
|
Nice catch with the distortion tests. I went ahead and backported the fix from #937 and re-enabled the distortion tests, which should now be fixed. |
chapulina
changed the title
Contributor
Author
|
@osrf-jenkins run tests please |
1 similar comment
Contributor
Author
|
@osrf-jenkins run tests please |
chapulina
force-pushed
the
triggered_test
branch
from
b08698b to
6e7d9a1
Compare
backport remove noe fix and re-enable distortion tests
chapulina
force-pushed
the
triggered_test
branch
from
1a92617 to
33d5ffd
Compare
Signed-off-by: Louise Poubel <[email protected]>
chapulina
changed the title
Contributor
Author
|
@shiveshkhaitan , it looks like most tests are fixed. The Ackermann is still flaky though. Mind taking another look at this PR? We can leave Ackermann for later. |
|
LGTM. All tests (including |
shiveshkhaitan
pushed a commit
to shiveshkhaitan/gazebo_ros_pkgs
that referenced
this pull request
Aug 15, 2019
* [ros2] Fix camera triggered test on Dashing backport remove noe fix and re-enable distortion tests * improve robustness of joint state pub test Signed-off-by: Louise Poubel <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #926. I think we missed this test because we usually don't compile rendering tests. When building with colcon, this enables the tests:
--cmake-args -DENABLE_DISPLAY_TESTS=true@shiveshkhaitan, mind taking a look? Thanks!