This repository was archived by the owner on Jul 10, 2025. It is now read-only.
[ros2] Fix test for diff drive#951
Merged
chapulina merged 1 commit intoros-simulation:dashingfrom Jul 9, 2019
Merged
Conversation
chapulina
approved these changes
Jul 9, 2019
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
Looks reasonable to me, let's try to run CI for it
Contributor
|
@ros-pull-request-builder retest this please |
Contributor
I think we need this to get CI working for the For now, I tested this locally and it works for me 👍 |
shiveshkhaitan
added a commit
to shiveshkhaitan/gazebo_ros_pkgs
that referenced
this pull request
Aug 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test should check for the linear velocity of the vehicle in the X direction wrt to the vehicle instead of linear velocity in Gazebo's X direction. This is how the odometry is also set.
gazebo_ros_pkgs/gazebo_plugins/src/gazebo_ros_diff_drive.cpp
Lines 574 to 575 in fa09083