This repository was archived by the owner on Jul 10, 2025. It is now read-only.
[ros2] Port elevator to ROS2#945
Merged
chapulina merged 1 commit intoros-simulation:dashingfrom Jul 11, 2019
Merged
Conversation
chapulina
approved these changes
Jul 11, 2019
Contributor
chapulina
left a comment
There was a problem hiding this comment.
Works for me!
I noticed that the elevator sometimes doesn't respond to commands. I needed to send a command a couple of times before it moved. But the problem seems to be in the Gazebo plugin, because I checked that the MoveToFloor commands are going through.
Merging!
| impl_->top_ = _sdf->Get<int>("top_floor", std::numeric_limits<int>::max()).first; | ||
| } | ||
|
|
||
| void GazeboRosElevator::OnElevator(const std_msgs::msg::String::ConstSharedPtr msg) |
Contributor
There was a problem hiding this comment.
So strange that the original plugin takes a string when we need an int 🤔 We could easily change this to Int32 for a cleaner implementation.
I wonder if it was done like this because Gazebo's ElevatorPlugin uses a string message. And the reason for that is that gazebo::msgs doesn't have an integer message...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port
gazebo_ros_elevatorplugin to ROS2.Example:
Migration guide at ROS 2 Migration: Elevator