This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Port wheel slip plugin to ros2 (forward port from eloquent)#1148
Merged
scpeters merged 3 commits intoros-simulation:ros2from Aug 17, 2020
Merged
Port wheel slip plugin to ros2 (forward port from eloquent)#1148scpeters merged 3 commits intoros-simulation:ros2from
scpeters merged 3 commits intoros-simulation:ros2from
Conversation
Initial port of gazebo_ros_wheel_slip_plugin to ros2. It includes a similar change to ros-simulation#1111, which moved the WheelSlipPlugin::Load call before the parameter callback so that the values from SDF/URDF are set first. Then the callback is changed to ignore negative values, and the default slip parameter values are set to -1, so that the SDF/URDF values are still preferred unless a different parameter value is specified in a launch file. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
jacobperron
reviewed
Aug 13, 2020
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a forward port of #1099.
Initial port of gazebo_ros_wheel_slip_plugin to ros2.
It includes a similar change to #1111, which moved the
WheelSlipPlugin::Load call before the parameter callback
so that the values from SDF/URDF are set first.
Then the callback is changed to ignore negative values, and the
default slip parameter values are set to -1, so that the SDF/URDF
values are still preferred unless a different parameter value
is specified in a launch file.