This repository was archived by the owner on Jul 10, 2025. It is now read-only.
gazebo_ros_wheel_slip plugin (Noetic)#1081
Merged
chapulina merged 2 commits intoros-simulation:noetic-develfrom May 15, 2020
Merged
gazebo_ros_wheel_slip plugin (Noetic)#1081chapulina merged 2 commits intoros-simulation:noetic-develfrom
chapulina merged 2 commits intoros-simulation:noetic-develfrom
Conversation
Uses dynamic_reconfigure to set wheel slip parameters. Requires gazebo 9.5. * don't overwrite initial slip values * Add test world using trisphere_cycles
jacobperron
approved these changes
Apr 16, 2020
Collaborator
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
LGTM
I'm not sure what our CI procedure is for Noetic. I guess this package still needs to be released into Noetic for automatic PR jobs to trigger.
Contributor
We're currently blocked by
I think we could add CI for Noetic on https://build.osrfoundation.org using |
Member
Author
|
@ros-pull-request-builder retest this please |
Contributor
|
@ros-pull-request-builder retest this please |
Contributor
|
I haven't reviewed, but will merge since it has an approval. |
cohen39
pushed a commit
to cohen39/gazebo_ros_pkgs
that referenced
this pull request
Nov 15, 2021
* gazebo_ros_wheel_slip plugin Uses dynamic_reconfigure to set wheel slip parameters. Requires gazebo 9.5. * don't overwrite initial slip values * Add test world using trisphere_cycles * gazebo_ros_wheel_slip: remove unused member data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses dynamic_reconfigure to set wheel slip parameters. Forward port of #995.