This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Measure IMU orientation with respect to the world (noetic)#1057
Merged
scpeters merged 2 commits intoros-simulation:noetic-develfrom Mar 25, 2020
Merged
Measure IMU orientation with respect to the world (noetic)#1057scpeters merged 2 commits intoros-simulation:noetic-develfrom
scpeters merged 2 commits intoros-simulation:noetic-develfrom
Conversation
Report the IMU orientation from the sensor plugin with respect to the world frame. This complies with convention documented in REP 145: https://www.ros.org/reps/rep-0145.html In order to not break existing behavior, users should opt-in by adding a new SDF tag. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
approved these changes
Mar 11, 2020
Collaborator
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
One typo, otherwise LGTM
Change default value of initialOrientationAsReference to false and print deprecation warning if user explicitly sets it to true.
scpeters
force-pushed
the
imu_orientation_noetic
branch
from
d00232d to
c00f2a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report the IMU orientation from the sensor plugin with respect to the world frame.
This complies with convention documented in REP 145: https://www.ros.org/reps/rep-0145.html
This ports #1051 from Melodic forward to Noetic and changes the default from retaining the legacy behavior (initialOrientationAsReference == true) to complying with REP 145 by default (initialOrientationAsReference == false). It also prints a deprecation warning if the user explicitly sets
initialOrientationAsReferenceto true.cc @jacobperron