This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Image publishers use SensorDataQoSProfile #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other sensor publishers were updated previously to use the same profile (ros-simulation#926). I'm not sure if the image publishers were overlooked or the image_transport API didn't support setting the QoS profile at the time. Signed-off-by: Jacob Perron <[email protected]>
Merged
chapulina
approved these changes
Jan 11, 2020
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
LGTM, just waiting for CI
jacobperron
added a commit
to jacobperron/gazebo_ros_pkgs
that referenced
this pull request
Mar 3, 2020
All other sensor publishers were updated previously to use the same profile (ros-simulation#926). I'm not sure if the image publishers were overlooked or the image_transport API didn't support setting the QoS profile at the time. Signed-off-by: Jacob Perron <[email protected]>
jacobperron
added a commit
to jacobperron/gazebo_ros_pkgs
that referenced
this pull request
Apr 1, 2020
All other sensor publishers were updated previously to use the same profile (ros-simulation#926). I'm not sure if the image publishers were overlooked or the image_transport API didn't support setting the QoS profile at the time. Signed-off-by: Jacob Perron <[email protected]>
jacobperron
added a commit
to jacobperron/gazebo_ros_pkgs
that referenced
this pull request
Jun 11, 2020
All other sensor publishers were updated previously to use the same profile (ros-simulation#926). I'm not sure if the image publishers were overlooked or the image_transport API didn't support setting the QoS profile at the time. Signed-off-by: Jacob Perron <[email protected]>
jacobperron
added a commit
to jacobperron/gazebo_ros_pkgs
that referenced
this pull request
Jun 17, 2020
All other sensor publishers were updated previously to use the same profile (ros-simulation#926). I'm not sure if the image publishers were overlooked or the image_transport API didn't support setting the QoS profile at the time. Signed-off-by: Jacob Perron <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Jun 17, 2020
All other sensor publishers were updated previously to use the same profile (#926). I'm not sure if the image publishers were overlooked or the image_transport API didn't support setting the QoS profile at the time. Signed-off-by: Jacob Perron <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other sensor publishers were updated previously to use the same profile (#926).
I'm not sure if the image publishers were overlooked or the image_transport API didn't
support setting the QoS profile at the time.