Skip to content

Comments

Update for error_code_name_prefixes and action error_msg (#4341)#104

Merged
SteveMacenski merged 1 commit intoros-navigation:rollingfrom
ewak:feature/mw/4341_error_msg_2
Mar 4, 2025
Merged

Update for error_code_name_prefixes and action error_msg (#4341)#104
SteveMacenski merged 1 commit intoros-navigation:rollingfrom
ewak:feature/mw/4341_error_msg_2

Conversation

@ewak
Copy link
Contributor

@ewak ewak commented Feb 9, 2025

No description provided.

Signed-off-by: Mike Wake <macwake@gmail.com>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll openly admit that I'll probably blank on merging this with everything else since navigation2_tutorials aren't in my usual review list.

I'd suggest adding this PR and the docs PR into your PR's main text body so I can remember to merge them both together with the main code changes. Right now, this PR isn't linked in any way with your main code PR

@aosmw
Copy link

aosmw commented Feb 11, 2025

I'd suggest adding this PR and the docs PR into your PR's main text body so I can remember to merge them both together with the main code changes. Right now, this PR isn't linked in any way with your main code PR

Done with back reference to main PR - ros-navigation/navigation2#4460

@SteveMacenski SteveMacenski merged commit 8ddf0d6 into ros-navigation:rolling Mar 4, 2025
2 checks passed
pepisg pushed a commit to pepisg/navigation2_tutorials that referenced this pull request Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants