Feature/vector object server#766
Conversation
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
Sushant-Chavan
force-pushed
the
feature/vector_object_server
branch
from
f9f9d8d to
68f78ac
Compare
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
I will need to check back in on this after the software PR is made so I can check that they align, but some small things we can fix now!
Most of the requested changes are just language fixes
|
I'm not sure if this PR belongs here, as there is a new one related to the Vector Object Server in the author's branch: Sushant-Chavan/navigation2#2. Could you please clarify, @Sushant-Chavan? |
|
I asked a similar question in another thread 😉 His company is picking up this work as they intend to use it in a product which was the main reason this work kind of sputtered off on my end prior - we didn't have an end user that could really battle test it to make sure we didn't have glaring gaps and put some real miles on it before merging into Nav2 itself. |
|
Hello @ajtudela & @SteveMacenski, This is in preparation for an upcoming PR that will soon be created to the https://github.com/ros-navigation/navigation2. The PR on my fork is a temporary one to make sure most of the CI checks pass before opening a PR upstream. It also allows me to get an early feedback from my team. I have to fix a few failing CI checks (DCO) before I can open the upstream PR. At that point, I will setup the correct PR references and mark this PR as ready for review :) |
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
…van/docs.nav2.org into feature/vector_object_server
Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>
Sushant-Chavan
force-pushed
the
feature/vector_object_server
branch
from
17837c1 to
bd1148d
Compare
Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>
Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>
Sushant-Chavan
force-pushed
the
feature/vector_object_server
branch
from
5d831d0 to
f7e3a3b
Compare
Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>
Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>
Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>
Signed-off-by: Sushant Chavan <sushant.chavan@idealworks.com>
4 participants
This PR continues the work on the open but non-active PR #613
Minor cleanup and updates were made to refer to correspond to the changes in the feature PR