PathCompleteGoalChecker documentation and related changes#620
Closed
josephduchesne wants to merge 1 commit intoros-navigation:masterfrom
Closed
PathCompleteGoalChecker documentation and related changes#620josephduchesne wants to merge 1 commit intoros-navigation:masterfrom
josephduchesne wants to merge 1 commit intoros-navigation:masterfrom
Conversation
…in interface changes. Made PathCompleteGoalChecker the default in examples. Signed-off-by: Joseph Duchesne <josephgeek@gmail.com>
SteveMacenski
requested changes
Dec 14, 2024
| nav2_controller-plugins/pose_progress_checker.rst | ||
| nav2_controller-plugins/simple_goal_checker.rst | ||
| nav2_controller-plugins/stopped_goal_checker.rst | ||
| nav2_controller-plugins/path_complete_goal_checker.rst |
Member
There was a problem hiding this comment.
I don't think you committed this page 🙃
| The new argument `current_path` can be ignored by existing out of tree plugins that do not make use of it, once they are updated to use the new method signature. | ||
|
|
||
| New (default) Goal Checker Plugin: PathCompleteGoalChecker | ||
| ******************************************************** |
Member
There was a problem hiding this comment.
Annoyingly, the line length has to match the title for rst to properly render -- please add **
Collaborator
|
closing in favor of #816 |
Member
|
@josephduchesne thanks for your efforts here, its been absorbed as part of a mass controller server refactor that @mini-1235 has been up to! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be paired with ros-navigation/navigation2#4789