Skip to content

Document bt_navigator error_code_name_prefixes and error_msg#587

Merged
SteveMacenski merged 16 commits intoros-navigation:masterfrom
aosmw:feature/mw/bt_error_msg_586
Mar 4, 2025
Merged

Document bt_navigator error_code_name_prefixes and error_msg#587
SteveMacenski merged 16 commits intoros-navigation:masterfrom
aosmw:feature/mw/bt_error_msg_586

Conversation

@aosmw
Copy link
Contributor

@aosmw aosmw commented Aug 31, 2024

Documents featured added to support returning Error codes and messages from failed NavigateToPose/NavigateThroughPoses actions ros-navigation/navigation2#4341

@aosmw aosmw marked this pull request as draft August 31, 2024 10:17
@aosmw aosmw force-pushed the feature/mw/bt_error_msg_586 branch 2 times, most recently from 795dcae to 23e4b92 Compare August 31, 2024 10:28
@aosmw aosmw marked this pull request as ready for review August 31, 2024 10:53
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM

@aosmw aosmw force-pushed the feature/mw/bt_error_msg_586 branch from 8d20961 to ed98c63 Compare September 7, 2024 02:31
aosmw and others added 4 commits February 8, 2025 20:40
Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@ewak ewak force-pushed the feature/mw/bt_error_msg_586 branch from 6b2c1af to b43dff0 Compare February 8, 2025 10:27
@ewak ewak force-pushed the feature/mw/bt_error_msg_586 branch from b43dff0 to d423c40 Compare February 8, 2025 11:44
Signed-off-by: Mike Wake <macwake@gmail.com>
@ewak ewak force-pushed the feature/mw/bt_error_msg_586 branch from 151b1c4 to 4504681 Compare February 9, 2025 03:38
ewak added 3 commits February 11, 2025 20:14
Signed-off-by: Mike Wake <macwake@gmail.com>
…ros-navigation#586)

error_code_names - Jazzy and older
error_code_name_prefixes - Kilted and newer

Signed-off-by: Mike Wake <macwake@gmail.com>
Signed-off-by: Mike Wake <macwake@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski SteveMacenski merged commit f6a11d8 into ros-navigation:master Mar 4, 2025
4 checks passed
mini-1235 pushed a commit to mini-1235/docs.nav2.org that referenced this pull request Mar 21, 2025
…igation#587)

* Trim trailing whitespace

Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>

* Document behavior tree error_code_name_prefixes, error_msg

Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>

* address error_msg review comments

Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>

* Update migration/Jazzy.rst

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Improve mandatory migration for error_code_name_prefixes parameter (ros-navigation#586)

Signed-off-by: Mike Wake <macwake@gmail.com>

* Document navigator error code ranges (ros-navigation#586)

Signed-off-by: Mike Wake <macwake@gmail.com>

* More behavior tree error_msg migration clarity (ros-navigation#586)

Signed-off-by: Mike Wake <macwake@gmail.com>

* Add builtin error_code_name_prefixes to tutorial (ros-navigation#586)

Signed-off-by: Mike Wake <macwake@gmail.com>

* Some more s/error_code_names/error_code_name_prefixes (ros-navigation#586)

Signed-off-by: Mike Wake <macwake@gmail.com>

* Add error_code_id and error_msg to Wait action (ros-navigation#586)

Signed-off-by: Mike Wake <macwake@gmail.com>

* distinguish release for error_code_names and error_code_name_prefixes (ros-navigation#586)

error_code_names - Jazzy and older
error_code_name_prefixes - Kilted and newer

Signed-off-by: Mike Wake <macwake@gmail.com>

* Expand error code ranges for navigators (ros-navigation#586)

Signed-off-by: Mike Wake <macwake@gmail.com>

* Update configuration/packages/configuring-bt-navigator.rst

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update configuration/packages/configuring-bt-navigator.rst

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update migration/Jazzy.rst

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update Jazzy.rst

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Mike Wake <macwake@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Mike Wake <macwake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants