Document optional TwistStamped support#503
Merged
SteveMacenski merged 2 commits intoros-navigation:masterfrom Feb 5, 2024
Merged
Document optional TwistStamped support#503SteveMacenski merged 2 commits intoros-navigation:masterfrom
SteveMacenski merged 2 commits intoros-navigation:masterfrom
Conversation
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
SteveMacenski
requested changes
Jan 3, 2024
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
Needs migration guide entry since this is very important. Place this near the top of the page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged with ros-navigation/navigation2#3775.
Many of the behaviors inherit from TimedBehavior. Is it worth documenting the same parameter in all of them, or is there a better place to reduce docs duplication?