Skip to content

Added range sensor costmap layer to documentation#50

Merged
SteveMacenski merged 4 commits intoros-navigation:masterfrom
BytesRobotics:range-sensor-costmap
Aug 7, 2020
Merged

Added range sensor costmap layer to documentation#50
SteveMacenski merged 4 commits intoros-navigation:masterfrom
BytesRobotics:range-sensor-costmap

Conversation

@Michael-Equi
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • migration guide

====== =======
Type Default
------ -------
int ALL
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a string input?

====== =======
Type Default
------ -------
int False
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int != bool

====== =======
Type Default
------ -------
int 0.8
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int != 0.8

====== =======
Type Default
------ -------
int 1.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int != 1.0

==== =======
Type Default
---- -------
bool [""]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vector of strings?

@Michael-Equi
Copy link
Copy Markdown
Contributor Author

  • migration guide

Which migration guide would you like this in? Eloquent -> Foxy or Foxy -> Galactic?

@SteveMacenski
Copy link
Copy Markdown
Member

E to F, we dont change API so I can cherry pick this to Foxy. Its on the list ros-navigation/navigation2#1866 for inclusion next sync

@SteveMacenski SteveMacenski merged commit bbedac9 into ros-navigation:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants