Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions configuration/packages/configuring-behavior-server.rst
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,20 @@ Behavior Server Parameters
Description
Frequency to run behavior plugins.

:action_server_result_timeout:

====== ======= =======
Type Default Unit
------ ------- -------
double 10.0 seconds
====== ======= =======

Description
The timeout value (in seconds) for action servers to discard a goal handle if a result has not been produced. This used to default to
15 minutes in rclc but was changed to 10 seconds in this `PR #1012 <https://github.com/ros2/rcl/pull/1012>`_, which may be less than
Comment thread
SteveMacenski marked this conversation as resolved.
Outdated
some actions in Nav2 take to run.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all I'd add:

"For most applications, this should not need to be adjusted as long as the actions within the server do not exceed this deadline. This issue has been raised with OSRF to find another solution to avoid active goal timeouts for bookkeeping, so this is a semi-temporary workaround."



Comment thread
SteveMacenski marked this conversation as resolved.
:transform_tolerance:

============== =============================
Expand Down
13 changes: 13 additions & 0 deletions configuration/packages/configuring-bt-navigator.rst
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,19 @@ Parameters
Default timeout value (in milliseconds) while a BT action node is waiting for acknowledgement from an action server.
This value will be overwritten for a BT node if the input port "server_timeout" is provided.

:action_server_result_timeout:

====== ======= =======
Type Default Unit
------ ------- -------
double 900.0 seconds
====== ======= =======

Description
The timeout value (in seconds) for action servers to discard a goal handle if a result has not been produced. This used to default to
15 minutes in rclc but was changed to 10 seconds in this `PR #1012 <https://github.com/ros2/rcl/pull/1012>`_, which may be less than
some actions in Nav2 take to run.

:transform_tolerance:

====== ======= =======
Expand Down
14 changes: 14 additions & 0 deletions configuration/packages/configuring-controller-server.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,20 @@ Parameters
Description
Frequency to run controller (Hz).

:action_server_result_timeout:

====== ======= =======
Type Default Unit
------ ------- -------
double 10.0 seconds
====== ======= =======

Description
The timeout value (in seconds) for action servers to discard a goal handle if a result has not been produced. This used to default to
15 minutes in rclc but was changed to 10 seconds in this `PR #1012 <https://github.com/ros2/rcl/pull/1012>`_, which may be less than
some actions in Nav2 take to run.


:controller_plugins:

============== ==============
Expand Down
14 changes: 14 additions & 0 deletions configuration/packages/configuring-planner-server.rst
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,20 @@ Parameters
Description
Expected planner frequency. If the current frequency is less than the expected frequency, display the warning message.

:action_server_result_timeout:

====== ======= =======
Type Default Unit
------ ------- -------
double 10.0 seconds
====== ======= =======

Description
The timeout value (in seconds) for action servers to discard a goal handle if a result has not been produced. This used to default to
15 minutes in rclc but was changed to 10 seconds in this `PR #1012 <https://github.com/ros2/rcl/pull/1012>`_, which may be less than
some actions in Nav2 take to run.


Default Plugins
***************

Expand Down
14 changes: 14 additions & 0 deletions configuration/packages/configuring-smoother-server.rst
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,20 @@ Smoother Server Parameters
Description
TF transform tolerance.

:action_server_result_timeout:

====== ======= =======
Type Default Unit
------ ------- -------
double 10.0 seconds
====== ======= =======

Description
The timeout value (in seconds) for action servers to discard a goal handle if a result has not been produced. This used to default to
15 minutes in rclc but was changed to 10 seconds in this `PR #1012 <https://github.com/ros2/rcl/pull/1012>`_, which may be less than
some actions in Nav2 take to run.


:robot_base_frame:

============== =============================
Expand Down
14 changes: 14 additions & 0 deletions configuration/packages/configuring-waypoint-follower.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,20 @@ Parameters
Description
Rate to check for results from current navigation task.

:action_server_result_timeout:

====== ======= =======
Type Default Unit
------ ------- -------
double 900.0 seconds
====== ======= =======

Description
The timeout value (in seconds) for action servers to discard a goal handle if a result has not been produced. This used to default to
15 minutes in rclc but was changed to 10 seconds in this `PR #1012 <https://github.com/ros2/rcl/pull/1012>`_, which may be less than
some actions in Nav2 take to run.


:waypoint_task_executor_plugin:

============== ========================
Expand Down
8 changes: 8 additions & 0 deletions migration/Iron.rst
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,11 @@ New node in nav2_collision_monitor: Collision Detector

In this `PR #3693 <https://github.com/ros-planning/navigation2/pull/3500>`_ A new node was introduced in the nav2_collision_monitor: Collision Detector.
It works similarly to the Collision Monitor, but does not affect the robot's velocity. It will only inform that data from the configured sources has been detected within the configured polygons via message to the ``collision_detector_state`` topic that might be used by any external module (e.g. switching LED or sound alarm in case of collision).

Expose action server's result timeout
******************************************************

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ** need to match length for it to render properly


In this `PR #3787 <https://github.com/ros-planning/navigation2/pull/3787>`_ the timeout for action server's result was exposed in all nodes having action servers.
This is because in this `PR #1012 <https://github.com/ros2/rcl/pull/1012>`_ in rclc a change was introduced which makes action servers discard a goal handle if the result
is not produced within 10 seconds, when the default was set to 15 minutes before. Since actions in Nav2 may take more than 10 seconds to complete, the user has now the ability
Comment thread
SteveMacenski marked this conversation as resolved.
Outdated
to set this value through the ``action_server_result_timeout`` parameter, which defaults to 15 minutes in the ``bt_navigators`` and ``waypoint_follower`` and to 10 seconds in all other nodes.