-
Notifications
You must be signed in to change notification settings - Fork 269
Action result timeout #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
7dcda3b
6824d98
0ee71ee
22b3e72
21f5741
ad7cdf0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,6 +71,20 @@ Behavior Server Parameters | |
| Description | ||
| Frequency to run behavior plugins. | ||
|
|
||
| :action_server_result_timeout: | ||
|
|
||
| ====== ======= ======= | ||
| Type Default Unit | ||
| ------ ------- ------- | ||
| double 10.0 seconds | ||
| ====== ======= ======= | ||
|
|
||
| Description | ||
| The timeout value (in seconds) for action servers to discard a goal handle if a result has not been produced. This used to default to | ||
| 15 minutes in rclc but was changed to 10 seconds in this `PR #1012 <https://github.com/ros2/rcl/pull/1012>`_, which may be less than | ||
| some actions in Nav2 take to run. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For all I'd add: "For most applications, this should not need to be adjusted as long as the actions within the server do not exceed this deadline. This issue has been raised with OSRF to find another solution to avoid active goal timeouts for bookkeeping, so this is a semi-temporary workaround." |
||
|
|
||
|
|
||
|
SteveMacenski marked this conversation as resolved.
|
||
| :transform_tolerance: | ||
|
|
||
| ============== ============================= | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,3 +77,11 @@ New node in nav2_collision_monitor: Collision Detector | |
|
|
||
| In this `PR #3693 <https://github.com/ros-planning/navigation2/pull/3500>`_ A new node was introduced in the nav2_collision_monitor: Collision Detector. | ||
| It works similarly to the Collision Monitor, but does not affect the robot's velocity. It will only inform that data from the configured sources has been detected within the configured polygons via message to the ``collision_detector_state`` topic that might be used by any external module (e.g. switching LED or sound alarm in case of collision). | ||
|
|
||
| Expose action server's result timeout | ||
| ****************************************************** | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
|
||
| In this `PR #3787 <https://github.com/ros-planning/navigation2/pull/3787>`_ the timeout for action server's result was exposed in all nodes having action servers. | ||
| This is because in this `PR #1012 <https://github.com/ros2/rcl/pull/1012>`_ in rclc a change was introduced which makes action servers discard a goal handle if the result | ||
| is not produced within 10 seconds, when the default was set to 15 minutes before. Since actions in Nav2 may take more than 10 seconds to complete, the user has now the ability | ||
|
SteveMacenski marked this conversation as resolved.
Outdated
|
||
| to set this value through the ``action_server_result_timeout`` parameter, which defaults to 15 minutes in the ``bt_navigators`` and ``waypoint_follower`` and to 10 seconds in all other nodes. | ||
Uh oh!
There was an error while loading. Please reload this page.