Merged
Conversation
Update configuring-collision-monitor.rst
Fix PR comment
Fix PR comments
Collaborator
AlexeyMerzlyakov
left a comment
AlexeyMerzlyakov
left a comment
There was a problem hiding this comment.
Mostly, I agree with the idea and update. Please, check the review comments below.
Fix PR comments
Contributor
Author
|
@AlexeyMerzlyakov Thanks for investing so much time in this PR, I have updated the code to meet your requests. |
Collaborator
AlexeyMerzlyakov
left a comment
AlexeyMerzlyakov
left a comment
There was a problem hiding this comment.
A few nitpick comments and I think, this will be ready ToGo
Member
|
I'm happy when @AlexeyMerzlyakov is. |
AlexeyMerzlyakov
approved these changes
Sep 6, 2023
Collaborator
AlexeyMerzlyakov
left a comment
AlexeyMerzlyakov
left a comment
There was a problem hiding this comment.
One more change and we could merge it to master
configuration/packages/collision_monitor/configuring-collision-monitor-node.rst
Outdated
Show resolved
Hide resolved
…-monitor-node.rst
configuration/packages/collision_monitor/configuring-collision-monitor-node.rst
Outdated
Show resolved
Hide resolved
…-monitor-node.rst
Collaborator
|
Merged to master, please sync-up changes from this PR with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add better explanation on how to integrate collision monitor with nav2 stack.