Add collision detector documentation#451
Merged
SteveMacenski merged 11 commits intoros-navigation:masterfrom Aug 28, 2023
Merged
Add collision detector documentation#451SteveMacenski merged 11 commits intoros-navigation:masterfrom
SteveMacenski merged 11 commits intoros-navigation:masterfrom
Conversation
tonynajjar
changed the title
7 tasks
SteveMacenski
requested changes
Aug 3, 2023
Contributor
Author
|
Done I believe. Sorry if it's not as verbose as you would wish but I really need to move on with this contribution; it took much more time than expected |
configuration/packages/collision_monitor/configuring-collision-monitor-node.rst
Outdated
Show resolved
Hide resolved
configuration/packages/collision_monitor/configuring-collision-monitor-node.rst
Show resolved
Hide resolved
Member
|
otherwise LGTM in general, but I'll let @AlexeyMerzlyakov review as well when he's back from vacation |
SteveMacenski
requested changes
Aug 10, 2023
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
I'll let Alexey approve the content of the subpages with the changes, but LGTM structurally
configuration/packages/collision_monitor/configuring-collision-monitor-node.rst
Outdated
Show resolved
Hide resolved
configuration/packages/collision_monitor/configuring-collision-detector-node.rst
Outdated
Show resolved
Hide resolved
configuration/packages/collision_monitor/configuring-collision-detector-node.rst
Outdated
Show resolved
Hide resolved
configuration/packages/collision_monitor/configuring-collision-detector-node.rst
Outdated
Show resolved
Hide resolved
Member
|
One last thing from me - add an entry in the migration guide page for the new node to show off to the users! |
Contributor
Author
Added for Jazzy and Iron, so now we have to backport to Iron 😄 |
Member
|
Just @AlexeyMerzlyakov 's comments left but I'm happy when he is |
SteveMacenski
approved these changes
Aug 22, 2023
AlexeyMerzlyakov
approved these changes
Aug 28, 2023
Collaborator
AlexeyMerzlyakov
left a comment
AlexeyMerzlyakov
left a comment
There was a problem hiding this comment.
One nitpick comment and it is ready to-go
| ****************************************************** | ||
|
|
||
| In this `PR #3693 <https://github.com/ros-planning/navigation2/pull/3500>`_ A new node was introduced in the nav2_collision_monitor: Collision Detector. | ||
| It works similarly to the Collision Monitor, but does not affect the robot's velocity. It will only inform that data from the configured sources has been detected within the configured polygons via message to the ``collision_detector_state`` topic. No newline at end of file |
Collaborator
There was a problem hiding this comment.
... that might be used by any external module (e.g. switching LED or sound alarm in case of collision).
| ****************************************************** | ||
|
|
||
| In this `PR #3693 <https://github.com/ros-planning/navigation2/pull/3500>`_ A new node was introduced in the nav2_collision_monitor: Collision Detector. | ||
| It works similarly to the Collision Monitor, but does not affect the robot's velocity. It will only inform that data from the configured sources has been detected within the configured polygons via message to the ``collision_detector_state`` topic. No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| It works similarly to the Collision Monitor, but does not affect the robot's velocity. It will only inform that data from the configured sources has been detected within the configured polygons via message to the ``collision_detector_state`` topic. | |
| It works similarly to the Collision Monitor, but does not affect the robot's velocity. It will only inform that data from the configured sources has been detected within the configured polygons via message to the ``collision_detector_state`` topic that might be used by any external module (e.g. switching LED or sound alarm in case of collision). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros-navigation/navigation2#3500