Add new limit polygon description#412
Merged
SteveMacenski merged 10 commits intoros-navigation:masterfrom May 23, 2023
Merged
Conversation
7 tasks
Collaborator
AlexeyMerzlyakov
left a comment
AlexeyMerzlyakov
left a comment
There was a problem hiding this comment.
Please add the pull request description and reference to the original PR3519 from Nav2 where it related to, to have the proper history.
The "limit" is not a polygon type (as "Polygon" or "Circle"). It is new safety behavior (or action type, also used in the parameters and mentioned in the documentation), so please correct the description at migration guide.
Also, please add the LIMIT safety behavior (action type) to the CM's configuration page (configuration/packages/configuring-collision-monitor.rst).
Contributor
Author
|
Thanks for your review. |
SteveMacenski
requested changes
May 3, 2023
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
2 small changes and this LGTM for when I review / approve the main PR itself. Sorry for the delay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to ros-navigation/navigation2#3519 change