Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add touch event and converters #49

Merged
merged 3 commits into from
Jan 11, 2016
Merged

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Oct 15, 2015

Ok, finally I found a way write event driven code instead of #48
This will provide equiavalent functions as we had in naoqi_tactile.py

QUESTIONS:

  1. we had following error/warning message for every event callback, Any idea?
LeftBumperPressed 1
[E] 14911 qitype.object: No such property 100
[E] 14911 qitype.object: No such signal 100
LeftBumperPressed 0
[E] 14913 qitype.object: No such property 100
[E] 14913 qitype.object: No such signal 100
FrontTactilTouched 1
[E] 14912 qitype.object: No such property 100
[E] 14912 qitype.object: No such signal 100
  1. I tried to write this using template class but it couldn't, even class inheretance...

I'm not c++ programmer so I missed something, but even if I was able to compile them, we had runtime error as follows...

found a catkin URDF /opt/ros/indigo/share/naoqi_driver/share/urdf/pepper.urdf
Audio Extractor: Start
terminate called after throwing an instance of 'std::runtime_error'
  what():  Object<T> can only be used on registered object types. (N5naoqi18TouchEventRegisterE)(0)
Aborted (core dumped)

@k-okada
Copy link
Member Author

k-okada commented Oct 16, 2015

ok, finally I am able to refacter with template classes, still it outputs

LeftBumperPressed 1
[E] 14911 qitype.object: No such property 100
[E] 14911 qitype.object: No such signal 100
LeftBumperPressed 0
[E] 14913 qitype.object: No such property 100
[E] 14913 qitype.object: No such signal 100
FrontTactilTouched 1
[E] 14912 qitype.object: No such property 100
[E] 14912 qitype.object: No such signal 100

but it does working. @Karsten1987 @vrabaud , please review.
Note that this requires #47 for running.

@suryaambrose
Copy link
Member

Hi !

Sorry it took so long before someone replies. At first glance it seems good, I will try to take more time to review and test soon. I also do not really know right now how to get rid of your error outputs, I remember seeing these but not why or when. I'll investigate too.

@vrabaud
Copy link
Contributor

vrabaud commented Jan 10, 2016

@suryaambrose , can we merge that ? I think it blocks https://github.com/ros-naoqi/naoqi_driver/pull/56/commits (which has the same touch commits). Thx.

@suryaambrose
Copy link
Member

OK for me. I ran a test with Nao, it works fine.

About your "No such (property|signal) 100" errors, it is a bug in libqi that was solved in May:
aldebaran/libqi@793cb65
@vrabaud maybe we need to update something ? I am not completely familiar with ROS release process, and I don't know if libqi-release package is automatically updated or not with the original libqi.

Anyway this PR is not responsible, anyone using up-to-date libqi will not have those errors.

suryaambrose added a commit that referenced this pull request Jan 11, 2016
add touch event and converters
@suryaambrose suryaambrose merged commit 2b6037c into ros-naoqi:master Jan 11, 2016
@k-okada k-okada deleted the add_touch2 branch February 4, 2016 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants