Add motor xacro macro #8
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a xacro macro for motors in the
include/common_macros.urdf.xacro.If no mesh is provided in the new
config/motor.yamlthen a default box is used:Other changes I have made (or that could be made):
material_dark_greytodark_greyconfig/motor.yamlI removed the top levelmotor:like it is done inbase.yamlandfront_wheel.yaml. This makes the code shorter insidecommon_macros.urdf.xacro. Maybe this could be used for the other yaml files as well because the description is already in the dictionary name, e.g.motor_props,base_prop,wheel_props. I think havingbase_prop['base']...andwheel_props['wheel']...is a bit redundant. What do you think? This could be addressed in the future. Maybe there is a problem without the top level name?wheel-colored.stlfor diffbot, which should fix the color in Gazebo. Only now the color doesn't work in RViz (rims and tires will have the same color).