Skip to content

Conversation

@fjp
Copy link
Member

@fjp fjp commented Nov 9, 2020

I have added a xacro macro for motors in the include/common_macros.urdf.xacro.

image

If no mesh is provided in the new config/motor.yaml then a default box is used:

image

Other changes I have made (or that could be made):

  • renamed material: material_dark_grey to dark_grey
  • remove some whitespaces
  • For the config/motor.yaml I removed the top level motor: like it is done in base.yaml and front_wheel.yaml. This makes the code shorter inside common_macros.urdf.xacro. Maybe this could be used for the other yaml files as well because the description is already in the dictionary name, e.g. motor_props, base_prop, wheel_props. I think having base_prop['base']... and wheel_props['wheel']... is a bit redundant. What do you think? This could be addressed in the future. Maybe there is a problem without the top level name?
  • added a colored stl wheel file: wheel-colored.stl for diffbot, which should fix the color in Gazebo. Only now the color doesn't work in RViz (rims and tires will have the same color).
  • TODOs
    • Fix the wheel placement of diffbot
    • Add sensors (camera, RPLidar A2, Ultrasonic, ...). Maybe we could have a mesh folder for common sensors that are usable for different robots.
    • Add documentation (nearly the same as for the wheel)

@fjp fjp added the enhancement New feature or request label Nov 9, 2020
@fjp fjp closed this Nov 9, 2020
@fjp
Copy link
Member Author

fjp commented Nov 9, 2020

I reverted all commits (to avoid having two useless stl files in the git history) and closed this issue because I just saw that the colors/materials applied in Blender don't work in Gazebo. See the new PR #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant