Skip to content

Add Pop! OS detector #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dirk-thomas merged 1 commit into from
May 28, 2020
Merged

Add Pop! OS detector #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/os_detect.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Currently supported OSes:
- Gentoo
- Mint
- OS X
- Pop! OS
- Red Hat Linux
- Slackware
- Ubuntu
Expand Down Expand Up @@ -137,6 +138,10 @@ OS name definitions

Name used for OS X.

.. data:: OS_POP

Name used for Pop! OS.

.. data:: OS_RHEL

Name used for Red Hat Enterprise Linux.
Expand Down
4 changes: 3 additions & 1 deletion src/rospkg/os_detect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def get_codename(self):

class LsbDetect(OsDetector):
"""
Generic detector for Debian, Ubuntu, and Mint
Generic detector for Debian, Ubuntu, Mint, and Pop! OS
"""
def __init__(self, lsb_name, get_version_fn=None):
self.lsb_name = lsb_name
Expand Down Expand Up @@ -731,6 +731,7 @@ def get_codename(self):
OS_TIZEN = 'tizen'
OS_SAILFISHOS = 'sailfishos'
OS_OSX = 'osx'
OS_POP = 'pop'
OS_QNX = 'qnx'
OS_RHEL = 'rhel'
OS_SLACKWARE = 'slackware'
Expand Down Expand Up @@ -764,6 +765,7 @@ def get_codename(self):
OsDetect.register_default(OS_TIZEN, FdoDetect("tizen"))
OsDetect.register_default(OS_SAILFISHOS, FdoDetect("sailfishos"))
OsDetect.register_default(OS_OSX, OSX())
OsDetect.register_default(OS_POP, LsbDetect("Pop"))
OsDetect.register_default(OS_QNX, QNX())
OsDetect.register_default(OS_RHEL, Rhel())
OsDetect.register_default(OS_SLACKWARE, Slackware())
Expand Down