Clean up shebang warnings#159
Merged
dirk-thomas merged 1 commit intoros-infrastructure:masterfrom Mar 26, 2019
cottsay:shebangs
Merged
Clean up shebang warnings#159dirk-thomas merged 1 commit intoros-infrastructure:masterfrom cottsay:shebangs
dirk-thomas merged 1 commit intoros-infrastructure:masterfrom
cottsay:shebangs
Conversation
Member
I don't think making the Python module executable is necessary - in the installed case the file shouldn't be executable. I would choose 1.a. instead. The
👍 |
nuclearsandwich
pushed a commit
to ros-infrastructure/rosdep
that referenced
this pull request
Nov 2, 2018
Two classes of changes here: 1. `catkin_support.py` is executable, but has no shebang, so I removed the executable bit. 2. `main.py` has a shebang and `__main__` handler, and I removed it. It can still be executed directly using the python executable, but like with ros-infrastructure/rospkg#159, it doesn't make sense to have executable scripts in the module.
at-wat
pushed a commit
to at-wat/rosdep
that referenced
this pull request
Nov 15, 2018
Two classes of changes here: 1. `catkin_support.py` is executable, but has no shebang, so I removed the executable bit. 2. `main.py` has a shebang and `__main__` handler, and I removed it. It can still be executed directly using the python executable, but like with ros-infrastructure/rospkg#159, it doesn't make sense to have executable scripts in the module.
This was referenced Nov 15, 2018
Member
|
Please comment on the PR after updating the patch. I just saw the changes by accident. Anyway it looks good to me now. Thanks for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are minor clean-ups for issues discovered during Fedora packaging. To date, these issues have been addressed in the packaging workflow directly. Moving the changes upstream means we can remove the workarounds in the packaging workflows.
Examples of the errors we're seeing from rpmlint:
There are two related changes here:
os_detect.pyhas a shebang and__main__, but isn't executable. Either:a. The shebang should be removed (this is the change I'm proposing, after feedback)
b. The file should be made executable
(this is the change I'm proposing)rosversion.pyhas a shebang, but no__main__handler. Either:a. The shebang should be removed (this is the change I'm proposing)
b.
__main__should be added and the file should be made executable. Sinceconsole_scriptstakes care of this at installation time, I don't think this is the right thing to do.