add alias for Pop! OS by mikaelarguedas · Pull Request #757 · ros-infrastructure/rosdep

mikaelarguedas · 2020-05-06T18:04:11Z

(this will need a bump of the version of rospkg(-modules) once ros-infrastructure/rospkg#199 is part of a release)

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

emersonknapp

Very useful!

emersonknapp · 2020-06-18T00:51:42Z

@mikaelarguedas I'm not sure how to re-trigger the travis build, but force-pushing the commit with a new hash should do it

mikaelarguedas · 2020-06-18T06:20:41Z

@emersonknapp I believe this is still waiting for the dependant PR ros-infrastructure/rospkg#199 to be released for this PR to pass CI

emersonknapp · 2020-06-18T16:32:00Z

Ohh - yeah I forgot that releases aren't automatic heh

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

codecov-commenter · 2020-06-23T07:00:10Z

Codecov Report

Merging #757 into master will decrease coverage by 0.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
- Coverage   74.85%   74.84%   -0.02%     
==========================================
  Files          41       41              
  Lines        3214     3220       +6     
==========================================
+ Hits         2406     2410       +4     
- Misses        808      810       +2

Impacted Files	Coverage Δ
src/rosdep2/platforms/osx.py	`51.93% <0.00%> (ø)`
src/rosdep2/platforms/debian.py	`79.24% <71.42%> (-0.50%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1784da...51b959f. Read the comment docs.

mikaelarguedas · 2020-06-23T07:00:56Z

@tfoote dependencies have been updated to require the version of rospkg that has the Pop! OS detector

mikaelarguedas · 2020-07-18T12:43:02Z

@tfoote @nuclearsandwich Friendly ping

mikaelarguedas · 2020-08-12T20:27:54Z

friendly 🛎️ is there anything blocking this ?

tfoote · 2020-08-13T17:47:00Z

No, sorry just vacation backlog.

* Add Suite3 option with Ubuntu Focal (ros-infrastructure#734) Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * [update] Allow to process single ROS distro, fix 723 (ros-infrastructure#738) * [update] skip other distro if --rosdistro passed Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * ignore argument if specified distro doesnt exist * address review comments * update help message for rosdistro Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * Fix CI and reduce CI time (ros-infrastructure#739) * test newer python * use yaml.safe_load * pin PyYAML version for Python 3.4 * pass user flag to pip when needed * move slow jobs to the top to reduce CI time Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * Strip Alpine's patch version from OS codename (ros-infrastructure#716) * Resolve Alpine os_version_type using OsDetect * Reduced Alpine OS VERSION to Major.Minor * improve support for null entries (ros-infrastructure#726) * support null for entire OS and not only OS version syntax like 'ubuntu: null' will now be raising ResolutionError with relevant error message instead of InvalidData with obscure error message will also cover syntax like: " ubuntu: '*': null bionic: [foobar] " Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> Co-authored-by: Scott K Logan <logans@cottsay.net> * Use DNF installer on RHEL 8 and newer (ros-infrastructure#713) RHEL/CentOS 8 uses DNF by default. * Updates to YUM and DNF (ros-infrastructure#640) Output YUM, DNF and RPM versions with `--all-versions` and fix the format guide's default PM for Fedora. * tests: don't assume euid != 0 (ros-infrastructure#703) If tests rely on the environment being a certain way, they should ensure it meets its expectations. Update the tests to ensure they're testing multiple euid conditions, and setting it explicitly where required. Fix ros-infrastructure#702 Signed-off-by: Kyle Fazzari <kyle@canonical.com> * openSUSE package query and install enhancements (ros-infrastructure#729) * Enable PIP installer for openSUSE * openSUSE package detection with RPM capabilities Packages sometimes get renamed and their old name is kept as an rpm capability (like an alias), so the additional flag `--whatprovides` is passed to the `rpm` query. * Fix conditional dependencies when one package uses manifest.xml (ros-infrastructure#737) * Fix conditional dependencies when one package uses manifest.xml Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Return rosdeps as a list to avoid breaking the interface. Co-authored-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Guard next(inter) (ros-infrastructure#701) * guard next(inter) Fix ros-infrastructure#691 Signed-off-by: artivis <jeremie.deray@canonical.com> * Handle StopIteration with slightly less line noise. Co-authored-by: Steven! Ragnarök <steven@nuclearsandwich.com> * [Windows] Add console script entry point (ros-infrastructure#656) * Add console script entry point Add console script entry point for platforms (e.g. Windows) not supporting shebang. * remove scripts entry since we are using console_scripts. * fix bad merge. * fix SKIP_PYTHON_SCRIPTS case. Co-authored-by: Lou Amadio <ooeygui@users.noreply.github.com> * Depend on modules packages only to allow co-installability. (ros-infrastructure#750) When the rosdep modules package was split in [ros-infrastructure#731] the module dependencies weren't updated to only depend on modules packages themselves which prevents rosdep modules for python2 and python3 from actually being co-installable. I haven't yet audited to make sure there's no cli usage of these tools in the modules but it's Friday afternoon and I wanted to get this inked before I walked away. When I return to it I'll check for that before proceeding for reviews. * 0.19.0 * also install buildtool_export_depends (ros-infrastructure#753) not adding 'exec_depends' or 'build_export_depends' are both are included inside 'run_depends' Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> * Drop shebang from a non-executable file (ros-infrastructure#755) * add alias for Pop! OS (ros-infrastructure#757) * add alias for Pop! OS Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> Co-authored-by: Shane Loretz <sloretz@openrobotics.org> Co-authored-by: Mikael Arguedas <mikael.arguedas@gmail.com> Co-authored-by: Mark Hedley Jones <MarkHedleyJones@gmail.com> Co-authored-by: Scott K Logan <logans@cottsay.net> Co-authored-by: Kyle Fazzari <kyle@canonical.com> Co-authored-by: Bjar Ne <43565432+gleichdick@users.noreply.github.com> Co-authored-by: Jeremie Deray <deray.jeremie@gmail.com> Co-authored-by: Sean Yen <seanyen@microsoft.com> Co-authored-by: Lou Amadio <ooeygui@users.noreply.github.com>

add alias for Pop! OS

b7e90fe

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

mikaelarguedas mentioned this pull request May 6, 2020

Add Pop! OS detector ros-infrastructure/rospkg#199

Merged

emersonknapp approved these changes May 6, 2020

View reviewed changes

mikaelarguedas mentioned this pull request May 7, 2020

Please add POP! OS to the list of Rosdep sources #756

Closed

tfoote approved these changes May 18, 2020

View reviewed changes

mikaelarguedas added 2 commits June 23, 2020 08:33

depend on rospkg 1.2.7

69c6a20

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

fix unrelated flake8 error (E741)

51b959f

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

tfoote merged commit 2667916 into ros-infrastructure:master Aug 13, 2020

mikaelarguedas deleted the popos-alias branch August 13, 2020 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add alias for Pop! OS#757

add alias for Pop! OS#757
tfoote merged 3 commits intoros-infrastructure:masterfrom
mikaelarguedas:popos-alias

mikaelarguedas commented May 6, 2020 •

edited

Loading

Uh oh!

emersonknapp left a comment

Uh oh!

emersonknapp commented Jun 18, 2020

Uh oh!

mikaelarguedas commented Jun 18, 2020

Uh oh!

emersonknapp commented Jun 18, 2020

Uh oh!

codecov-commenter commented Jun 23, 2020 •

edited

Loading

Uh oh!

mikaelarguedas commented Jun 23, 2020

Uh oh!

mikaelarguedas commented Jul 18, 2020

Uh oh!

mikaelarguedas commented Aug 12, 2020

Uh oh!

tfoote commented Aug 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mikaelarguedas commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emersonknapp left a comment

Choose a reason for hiding this comment

Uh oh!

emersonknapp commented Jun 18, 2020

Uh oh!

mikaelarguedas commented Jun 18, 2020

Uh oh!

emersonknapp commented Jun 18, 2020

Uh oh!

codecov-commenter commented Jun 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mikaelarguedas commented Jun 23, 2020

Uh oh!

mikaelarguedas commented Jul 18, 2020

Uh oh!

mikaelarguedas commented Aug 12, 2020

Uh oh!

tfoote commented Aug 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mikaelarguedas commented May 6, 2020 •

edited

Loading

codecov-commenter commented Jun 23, 2020 •

edited

Loading