Fix the unit test test_get_gbprepo_as_rosdep_data#648
Closed
veimox wants to merge 1 commit intoros-infrastructure:masterfrom
veimox:bugfix/test_get_gbprepo_as_rosdep_data
Closed
Fix the unit test test_get_gbprepo_as_rosdep_data#648veimox wants to merge 1 commit intoros-infrastructure:masterfrom veimox:bugfix/test_get_gbprepo_as_rosdep_data
veimox wants to merge 1 commit intoros-infrastructure:masterfrom
veimox:bugfix/test_get_gbprepo_as_rosdep_data
Conversation
The unit test checks for the existance of thre keys ['ros', 'catkin', 'genmsg'] in the rosdep data gather from a distro. As coded, it gets the first distribution found in alphabetical order. As of today "ardent". However this is a ros2 distribution and, for example, catkin is not released for it (https://github.com/ros/rosdistro/blob/master/ardent/distribution.yaml)
Author
|
Closed in favor of #647 . I should have seen it before :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit test checks for the existence of three keys
['ros', 'catkin', 'genmsg']in the rosdep data gathered from a distro. As coded, it gets the first distribution found in alphabetical order. As of todayardent. However this is a ros2 distribution and, for example, catkin is not released for it.I propose to use
melodicas this is the latest ros1 distribution where those keys are guaranteed to be there. Otherwise, the keys can be change by removing "catkin" and "genmsg".