Add include support for aptly backed bootstrap repository.#33
Merged
nuclearsandwich merged 1 commit intomasterfrom Nov 26, 2019
Merged
Add include support for aptly backed bootstrap repository.#33nuclearsandwich merged 1 commit intomasterfrom
nuclearsandwich merged 1 commit intomasterfrom
Conversation
dirk-thomas
approved these changes
Nov 26, 2019
Member
|
I added "Fixes #31" to the description. |
nuclearsandwich
added a commit
to ros-infrastructure/catkin_pkg
that referenced
this pull request
Dec 3, 2019
This configuration option requires two recent changes in stdeb and ros_release_python: * stdeb/stdeb#147 * ros-infrastructure/ros_release_python#33 The option allows a different set of suites to be set for Python 3 releases allowing us to forestall releasing Python2 versions of these packages for platforms where we don't plan to support Python 2.
dirk-thomas
pushed a commit
to ros-infrastructure/catkin_pkg
that referenced
this pull request
Dec 3, 2019
This configuration option requires two recent changes in stdeb and ros_release_python: * stdeb/stdeb#147 * ros-infrastructure/ros_release_python#33 The option allows a different set of suites to be set for Python 3 releases allowing us to forestall releasing Python2 versions of these packages for platforms where we don't plan to support Python 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
--includeflag to work with the current aptly-based bootstrap repository. Fixes #31.Unlike #26 I actually had to touch the script itself.
Mostly I took information assumptions the script made about the structure of the include commands and moved it into the config values themselves.
I also needed to add a post_include_command option to trigger the snapshot and publish operation needed to push the include out to the published repositories.