Use chocolatey_package resource and pin cppcheck version.

[nuclearsandwich]

The latest round of testing has issues with cppcheck 2.0 which are still being worked on. We need to propagate the pin but I also saw and forgot why this was being done with an execute resource rather than a chocolatey_package resource.

So this PR includes two changes.

• Use chocolatey_package resource to install chocolatey packages.
• Install cppcheck at version 1.90.

[nuclearsandwich]

When running a test build of this PR it fails later on with a cffi installation but the chocolatey packages all seem to install correctly.

https://ci.ros2.org/job/test_ci_windows/185/ is running a non debug build to show us a successful build.

[brawner]

Thanks for the PR. I'm still racking my head. I'll try to do some digging myself for the history.

[brawner]

I can't find the explanation, but this original switch to using the command-line version happened here in #3

76e4f3d

[nuclearsandwich]

This branch was out of sync with master and thus having build issues. I've updated the branch to include master

If this build passes I think we'll be good to merge this change.

[nuclearsandwich]

If this build passes I think we'll be good to merge this change.

The cookbook converged and the build had only failures that are also in the most recent nightly so I think this gets us where we need to be.