Skip to content

Unpin cppcheck 1.90.#17

Open
nuclearsandwich wants to merge 1 commit intolatestfrom
nuclearsandwich/unpin-cppcheck
Open

Unpin cppcheck 1.90.#17
nuclearsandwich wants to merge 1 commit intolatestfrom
nuclearsandwich/unpin-cppcheck

Conversation

@nuclearsandwich
Copy link
Copy Markdown
Contributor

This will install the latest version of cppcheck available from
chocolatey.

Replaces ros2/ci#480's direct revert.

@brawner
Copy link
Copy Markdown
Collaborator

brawner commented Oct 9, 2020

This looks similar to a draft that @jacobperron showed me trying to debug an issue. It resulted in the error below, hopefully you're not running into the same issue:

https://ci.ros2.org/job/ci_windows/12370/console

@jacobperron
Copy link
Copy Markdown
Collaborator

jacobperron commented Oct 9, 2020

The error I ran into went away when I pushed my change to this repository (versus trying to run CI against a fork of ros2-cookbooks).

@nuclearsandwich
Copy link
Copy Markdown
Contributor Author

This looks similar to a draft that @jacobperron showed me trying to debug an issue. It resulted in the error below, hopefully you're not running into the same issue:

Yeah I saw an existing branch but wasn't sure what it's deal was since there was no attached PR.

This will install the latest version of cppcheck available from
chocolatey.

Replaces ros2/ci#480's direct revert.

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@clalancette clalancette force-pushed the nuclearsandwich/unpin-cppcheck branch from a4c8837 to 4364c57 Compare March 9, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants