Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of "Quick stop" vs. "halt" #260

Open
gsalinas opened this issue Feb 17, 2024 · 0 comments
Open

Naming of "Quick stop" vs. "halt" #260

gsalinas opened this issue Feb 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@gsalinas
Copy link

gsalinas commented Feb 17, 2024

As best as I can tell from reading through the source code, the ~/halt service of a canopen_402_driver node is actually implemented by setting the Quick Stop bit of the control word. Reading the CIA402 specification, I understand that many CIA402 motion devices implement both a "quick stop" and a "halt" functionality - control word bit 2 and control word bit 8, respectively - so it's probably somewhat misleading that the ROS service calls itself "halt" when it's more properly a quick stop.

I think the best solution would be to rename the service to quick stop and introduce a new service called halt which actually implements halting by setting bit 8, although admittedly this could be a breaking change for any current users of halt. I'm not sure how to handle that part of it but I wanted to make you all aware of the discrepancy.

Thank you so much!

@gsalinas gsalinas added the enhancement New feature or request label Feb 17, 2024
@ipa-vsp ipa-vsp added this to the Beta-Release - 0.3.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants