Install llvm repository for newer versions of clang-format #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave992
force-pushed
the
recent_clang_format_version
branch
from
7d16042 to
1547277
Compare
For containers that do not run as root
dave992
force-pushed
the
recent_clang_format_version
branch
from
7ae2def to
1cc0528
Compare
|
This seems to be very specific to your use case.
This pulls more dependencies in, which are not needed for running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
CLANG_FORMAT_VERSIONwe can specify whichclang-formatversion to use. This assumes the version is available via apt.I wanted to be able to use more recent versions of
clang-formatuniformly across multiple different ROS versions. Being limited to what is available for the base image is somewhat restrictive in this case. Furthermore, the packages that are included in Ubuntu are quite old.The proposed changes check if the requested version is available via apt. If not, it will install the requested version using the Automatic installation script recommended by https://apt.llvm.org/