Skip to content

jade is EOL#351

Merged
mathias-luedtke merged 1 commit into
ros-industrial:masterfrom
mathias-luedtke:jade-eol
Apr 6, 2019
Merged

jade is EOL#351
mathias-luedtke merged 1 commit into
ros-industrial:masterfrom
mathias-luedtke:jade-eol

Conversation

@mathias-luedtke
Copy link
Copy Markdown
Member

Use kinetic in tests and documentation instead.

Travis and Gitlab builds are failing at rosdep install step.
Not sure what changed 2 weeks ago.

use kinetic in tests and documentation instead
@mathias-luedtke mathias-luedtke requested a review from 130s January 27, 2019 10:32
@mathias-luedtke
Copy link
Copy Markdown
Member Author

Ah, ros-infrastructure/rosdep#647 happened

@mathias-luedtke mathias-luedtke changed the title jade is EOL [WIP] jade is EOL Jan 27, 2019
@mathias-luedtke
Copy link
Copy Markdown
Member Author

mathias-luedtke commented Jan 27, 2019

I'd like to roll out a fix first, because indigo and lunar will be EOL in a couple of months as well.

Copy link
Copy Markdown
Member

@130s 130s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

I leave the decision up to you to merge as this PR is still WIP and I'm not sure what you mean at #351 (comment)

@mathias-luedtke
Copy link
Copy Markdown
Member Author

I meant #352, it will fix our builds as well.
We might want to keep the EOL jobs for now to test this fix.

@mathias-luedtke mathias-luedtke changed the title [WIP] jade is EOL jade is EOL Apr 6, 2019
@mathias-luedtke mathias-luedtke merged commit 5590600 into ros-industrial:master Apr 6, 2019
@mathias-luedtke mathias-luedtke deleted the jade-eol branch May 10, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants